Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added No Filter conditional to FilterChips (CRASM-803) #731

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

hawkishpolicy
Copy link
Collaborator

🗣 Description

  • Added conditional to render "No Filter(s) Applied" FilterChip when no filters are applied.
  • Only applies to GlobalAdmins as Regional Admins and Standard Users cannot remove their default filters.

💭 Motivation and context

🧪 Testing

  • tested locally.

📷 Screenshots (if appropriate)

Screenshot 2024-12-02 at 2 00 44 PM Screenshot 2024-12-02 at 2 01 06 PM Screenshot 2024-12-02 at 2 01 27 PM Screenshot 2024-12-02 at 2 09 40 PM
Screen.Recording.2024-12-02.at.2.02.06.PM.mov

r

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

- Added conditional to render No Filter(s) Applied when no filters are applied.
- Only applies to GlobalAdmins as Regional Admins and Standard Users cannot remove their default filters.
@hawkishpolicy hawkishpolicy self-assigned this Dec 2, 2024
Copy link
Collaborator

@chrtorres chrtorres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@lwersiy lwersiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants