Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add request field to Domain and Vulnerability endpoints #742

Merged
merged 5 commits into from
Dec 18, 2024

Conversation

JCantu248
Copy link
Collaborator

🗣 Description

Added the request field to the Domain and Vulnerability field, which contains a JSON list of their respective objects. Also updated the Pytest cases to ensure the endpoint still works as expected.

💭 Motivation and context

Change is required since the frontend expects the response in the form of a request: [] object.

🧪 Testing

Test cases were updated in response to these changes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

x

@JCantu248 JCantu248 added test This issue or pull request adds or otherwise modifies test code backend labels Dec 12, 2024
@JCantu248 JCantu248 self-assigned this Dec 12, 2024
@aloftus23 aloftus23 merged commit 240f453 into integration Dec 18, 2024
7 of 14 checks passed
@aloftus23 aloftus23 deleted the JD-add-request-field-to-response branch December 18, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend test This issue or pull request adds or otherwise modifies test code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants