Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Severity Level Validation Improvements #747

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Severity Level Validation Improvements #747

wants to merge 7 commits into from

Conversation

hawkishpolicy
Copy link
Collaborator

  • Refined and uniformed the grouping and sorting logic of irregular severity levels in the Vulns Bar Chart and All Vulns Table components.

🗣 Description

  • Null, undefined, empty strings, and stringified versions on Null, N/A, and undefined are now grouped into the N/A category in both the Vulns Bar Chart and All Vulns table.
  • Both components now force Title Case on the severity level strings first then sort and group into their respective categories.
  • Edited the comparator function in the All Vulns tables to sort the severity levels in the correct order from N/A, Low, Medium, High, Critical, Other.

💭 Motivation and context

  • Improves sorting and grouping of irregular severity levels.

🧪 Testing

  • Seeded local DB with irregular values.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@hawkishpolicy
Refined Severity Levels filtering in Bar Chart
3f7de25 
- Ensured N/A severity level in Bar Chart includes all permutations of null, undefined, and empty strings.
- Ensured filtering by severity level in All Vulns table matches the filtering in the Bar Chart.
@hawkishpolicy
Added to-do for N/A values array
e5a8017
@hawkishpolicy
Refined Severity Level sorting and grouping
c562310 
- Null, undefined, empty strings, and stringified versions on Null, N/A, and undefined are now grouped into the N/A category in both the Vulns Bar Chart and All Vulns table.
- Both components now force Title Case on the severity level strings first then sort and group into their respective categories.
- Edited the comporator function in the All Vulns tables to sort the severity levels in the correct order from N/A, Low, Medium, High, Critical, Other.
@hawkishpolicy hawkishpolicy self-assigned this Dec 27, 2024
@hawkishpolicy
Removed unnecessary if statement from Comparator
2da4510 
- Adjusted the number values of the severity levels object to start with 1 instead of 0.
- This removes the need for the long if statement previously used to handle N/A values.
@hawkishpolicy
Removed unused console.logs and variables
cbd704d
@hawkishpolicy
Refactored if statement for N/A values
1afe5c3
@hawkishpolicy
Removed console.logs and unused variables
ffa2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloftus23 aloftus23 Awaiting requested review from aloftus23 aloftus23 will be requested when the pull request is marked ready for review aloftus23 is a code owner

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 will be requested when the pull request is marked ready for review cduhn17 is a code owner

@Matthew-Grayson Matthew-Grayson Awaiting requested review from Matthew-Grayson Matthew-Grayson will be requested when the pull request is marked ready for review Matthew-Grayson is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola will be requested when the pull request is marked ready for review nickviola is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 will be requested when the pull request is marked ready for review rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 will be requested when the pull request is marked ready for review schmelz21 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hawkishpolicy hawkishpolicy

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hawkishpolicy