Remove stale and unused code #771
Conversation
cduhn17
requested review from
dav3r,
felddy,
jsf9k,
mcdonnnj,
aloftus23,
Matthew-Grayson,
nickviola,
rapidray12 and
schmelz21
as code owners
| @@ -123,7 +123,7 @@ jobs: | |||
| SLS_DEBUG: '*' | |||
|
|
|||
| - name: Deploy worker | |||
| run: npm run deploy-worker-staging | |||
| run: npm run deploy-worker.sh-staging | |||
There was a problem hiding this comment.
Changes to this file shouldn't be necessary. Need to remove both changes.
deploy-worker is an alias defined in backend/package.json so shouldn't have .sh in it. Same with deploy-worker-integration
| @@ -2,7 +2,7 @@ | |||
| # Deploys worker to Terraform. | |||
| # If the worker_ecs_repository_url output from Terraform changes, you should replace "XXX.dkr.ecr.us-east-1.amazonaws.com" in this file with that URL. | |||
| # To deploy staging, run ./deploy-worker.sh. | |||
| # To deploy prod, run ./deploy-worker.sh crossfeed-prod-worker. | |||
| # To deploy prod, run ./deploy-worker.sh.sh crossfeed-prod-worker. | |||
There was a problem hiding this comment.
Typo here. No changes needed to this file.
| @@ -21,7 +32,11 @@ | |||
| "url": "git+https://github.com/cisagov/crossfeed.git" | |||
| }, | |||
| "scripts": { | |||
| "start": "docker compose build --parallel && docker compose up --force-recreate" | |||
| "lint": "eslint '**/*.{ts,tsx,js,jsx}'", | |||
There was a problem hiding this comment.
Shouldn't need to change this file except for your es addition. These are all the packages installed in the frontend lambda so we should be careful to add anything that isn't necessary.
This all might be fine just think we should triple-check any changes here.
| api: | ||
| handler: src.xfd_django.xfd_django.asgi.handler | ||
| events: | ||
| - http: |
There was a problem hiding this comment.
Typo. This file needs to be called functions.yml instead of .yaml
There was a problem hiding this comment.
file extension updated per this request at commit 6b598c2
|
@cduhn17 Still a couple small fixes needed that I mentioned above. Otherwise looks good. |
🗣 Description
Removed outdated and redundant code across the legacy TypeScript backend to improve clarity, maintainability, and overall project efficiency.
💭 Motivation and context
This change removes outdated TypeScript backend code to reduce technical debt and eliminate confusion from unused components. Replacing FastAPI with Django made the legacy TypeScript API obsolete, ensuring a cleaner, more maintainable codebase.
✅ Pre-approval checklist
in code comments.
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist