Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities integration tests #774

Merged
merged 7 commits into from
Feb 4, 2025

Conversation

jyang2139
Copy link
Collaborator

🗣 Description

Added integration testing for Vulnerabilities endpoint for get, put, post.

💭 Motivation and context

Integration tests were created by building on existing unit and integration tests. These tests ensure that the GET, PUT, and POST methods work correctly and that the system components interact as expected.

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.

✅ Post-merge checklist

  • Create a release.

@JCantu248
Copy link
Collaborator

Looks good, but lets rerun the pre-commit hooks locally. Theres some linter errors that need to be resolved locally. Then add the files, commit, and push again.

The code looks good. I'll work on resolving some of these environment search values and integrating them into Github Actions.

@JCantu248 JCantu248 merged commit a083545 into JD_integration_tests Feb 4, 2025
4 of 6 checks passed
@JCantu248 JCantu248 deleted the jy_integration_tests branch February 4, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants