Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update code to use the "docker compose" syntax vice "docker-compose" #58

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Update code to use the "docker compose" syntax vice "docker-compose" #58

merged 1 commit into from
Jun 23, 2022

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jun 7, 2022

🗣 Description

This pull request updates the code to use the docker compose syntax instead of the docker-compose syntax.

💭 Motivation and context

The docker compose syntax is the preferred (and only correct) syntax after the changes in cisagov/ansible-role-docker#60.

🧪 Testing

Automated testing passes.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

@jsf9k
Update code to use the "docker compose" syntax vice "docker-compose"
4c45825 
The "docker compose" syntax is the preferred (and only correct) syntax
after the changes in cisagov/ansible-role-docker#60.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality breaking change This issue or pull request involves changes to existing functionality labels Jun 7, 2022
@jsf9k jsf9k self-assigned this Jun 7, 2022
@jsf9k jsf9k marked this pull request as ready for review June 7, 2022 21:11
@jsf9k jsf9k requested a review from dav3r as a code owner June 7, 2022 21:12
@jsf9k jsf9k requested a review from mcdonnnj June 7, 2022 21:14
dav3r
dav3r approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

dav3r
dav3r approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k merged commit cf93d24 into develop Jun 23, 2022
@jsf9k jsf9k deleted the bugfix/update-docker-compose-syntax branch June 23, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@jsf9k jsf9k

Labels
breaking change This issue or pull request involves changes to existing functionality bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @mcdonnnj