Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

feature: Add Send Notification Email Endpoint #10

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

itsmostafa
Copy link
Contributor

@itsmostafa itsmostafa commented Feb 15, 2023

Add send notification email endpoint

🗣 Description

Updated all endpoints with url prefix tasks/ to avoid conflict with con-pca-api endpoints and the frontend
Added NewSESEmail so that it can be initialized once for performance benefits

💭 Motivation and context

Create an endpoint that will eventually be consumed by con-pca-api for manually sending notification emails

🧪 Testing

tested locally

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@itsmostafa itsmostafa marked this pull request as ready for review February 15, 2023 20:10
@itsmostafa itsmostafa requested a review from izzy64 as a code owner February 15, 2023 20:10
Copy link
Contributor

@izzy64 izzy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmostafa itsmostafa merged commit bbadb2d into develop Feb 15, 2023
@itsmostafa itsmostafa deleted the feature/add-email-notification-endpoint branch February 15, 2023 20:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants