Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

fix init when calling version flag #29

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix init when calling version flag #29

merged 1 commit into from
Mar 14, 2023

Conversation

itsmostafa
Copy link
Contributor

-version flag is failing due to db and aws clients initialized before hand

🗣 Description

initialize all clients only when -version flag is not called.

💭 Motivation and context

🧪 Testing

tested locally

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@itsmostafa itsmostafa marked this pull request as ready for review March 14, 2023 16:40
@itsmostafa itsmostafa requested a review from izzy64 as a code owner March 14, 2023 16:40
@itsmostafa itsmostafa merged commit 0e52c4f into develop Mar 14, 2023
@itsmostafa itsmostafa deleted the fix/init-after-version branch March 14, 2023 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@izzy64 izzy64 izzy64 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsmostafa @izzy64