Skip to content
This repository has been archived by the owner on Sep 22, 2023. It is now read-only.

fix: release workflow #7

Merged
merged 17 commits into from
Feb 9, 2023
Merged

fix: release workflow #7

merged 17 commits into from
Feb 9, 2023

Conversation

itsmostafa
Copy link
Contributor

@itsmostafa itsmostafa commented Feb 3, 2023

fix inconsistencies in the matrix build to avoid binaries failing to run in github actions.

🗣 Description

removed the unused os var in the matrix
removed the duplicate bins outside of includes

💭 Motivation and context

tests were failing in cisagov/con-pca-tasks-docker repo

🧪 Testing

will be testing when this PR is merged as binaries already successfully run on
my local machine

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Add a tag or create a release.

@itsmostafa itsmostafa marked this pull request as ready for review February 3, 2023 00:33
.github/workflows/release.yml Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@itsmostafa itsmostafa requested a review from mcdonnnj February 3, 2023 16:20
@itsmostafa itsmostafa requested a review from izzy64 as a code owner February 3, 2023 21:05
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch from 43fc612 to e441448 Compare February 6, 2023 16:54
@itsmostafa itsmostafa marked this pull request as draft February 6, 2023 16:56
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch 7 times, most recently from 4c4f569 to 1b0d636 Compare February 6, 2023 20:43
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch from 1b0d636 to e440025 Compare February 6, 2023 20:51
@itsmostafa itsmostafa marked this pull request as ready for review February 6, 2023 21:00
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch from d27cd04 to 1fd71c7 Compare February 6, 2023 21:07
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch from 1fd71c7 to 41fb683 Compare February 6, 2023 21:28
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch from 67963f0 to 1ae1ae5 Compare February 6, 2023 23:11
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all looking pretty good. I have some small suggestions for your consideration.

.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@itsmostafa itsmostafa force-pushed the fix/release-workflow branch from 06bd936 to bc9359a Compare February 7, 2023 18:21
@itsmostafa itsmostafa requested a review from mcdonnnj February 7, 2023 18:25
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough ✔

Copy link
Contributor

@izzy64 izzy64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itsmostafa itsmostafa merged commit a351c0f into develop Feb 9, 2023
@itsmostafa itsmostafa deleted the fix/release-workflow branch February 9, 2023 16:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants