This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmostafa
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
February 3, 2023 00:33
mcdonnnj
suggested changes
Feb 3, 2023
itsmostafa
force-pushed
the
fix/release-workflow
branch
from
February 6, 2023 16:54
43fc612
to
e441448
Compare
itsmostafa
force-pushed
the
fix/release-workflow
branch
7 times, most recently
from
February 6, 2023 20:43
4c4f569
to
1b0d636
Compare
itsmostafa
force-pushed
the
fix/release-workflow
branch
from
February 6, 2023 20:51
1b0d636
to
e440025
Compare
itsmostafa
force-pushed
the
fix/release-workflow
branch
from
February 6, 2023 21:07
d27cd04
to
1fd71c7
Compare
itsmostafa
force-pushed
the
fix/release-workflow
branch
from
February 6, 2023 21:28
1fd71c7
to
41fb683
Compare
itsmostafa
force-pushed
the
fix/release-workflow
branch
from
February 6, 2023 23:11
67963f0
to
1ae1ae5
Compare
mcdonnnj
suggested changes
Feb 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all looking pretty good. I have some small suggestions for your consideration.
itsmostafa
force-pushed
the
fix/release-workflow
branch
from
February 7, 2023 18:21
06bd936
to
bc9359a
Compare
mcdonnnj
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable enough ✔
izzy64
approved these changes
Feb 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix inconsistencies in the matrix build to avoid binaries failing to run in github actions.
🗣 Description
removed the unused
os
var in the matrixremoved the duplicate
bins
outside of includes💭 Motivation and context
tests were failing in
cisagov/con-pca-tasks-docker
repo🧪 Testing
will be testing when this PR is merged as binaries already successfully run on
my local machine
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist