This repository has been archived by the owner on Sep 22, 2023. It is now read-only.
feature: add dispatch to docker repo #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
from
0dc8176
to
3b9a355
Compare
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
15 times, most recently
from
c69785c
to
d1e284b
Compare
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
6 times, most recently
from
3603da3
to
6ba8f86
Compare
itsmostafa
requested review from
dav3r,
felddy,
jsf9k and
mcdonnnj
as code owners
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
from
6ba8f86
to
ce4386f
Compare
itsmostafa
changed the title
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
from
ce4386f
to
1a1b5f4
Compare
jsf9k
approved these changes
Feb 10, 2023
mcdonnnj
reviewed
Feb 10, 2023
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
from
acf5a9d
to
acfccc9
Compare
mcdonnnj
reviewed
Feb 11, 2023
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
from
bbd95f5
to
a2c52b9
Compare
mcdonnnj
reviewed
Feb 14, 2023
There was a problem hiding this comment.
You disabled CGo in the build workflow but have not made a corresponding change in the release workflow. Was this intentional? You should also update the pull request description to mention CGo being disabled (either in the build workflow or in general) as part of the work.
@mcdonnnj good catch. I forgot to disable it in the release. I also updated the PR description. Resolved with 29eb4a6 |
itsmostafa
force-pushed
the
feature/add-dispatch-docker-repo
branch
from
29eb4a6
to
7c4c53c
Compare
mcdonnnj
suggested changes
Feb 14, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a dispatch step to trigger a build at
cisagov/con-pca-tasks-dockerrepo🗣 Description
Dispatch step depends on a release being completed.
Disabled CGO as it's not needed to run C libraries and allows for a performance boost.
💭 Motivation and context
Part of the effort to automate deployments
🧪 Testing
will be testing within this PR's gha checks
✅ Pre-approval checklist
to reflect the changes in this PR.