Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two additional permissions to ProvisionPublishEgressIP policy #144

Merged
merged 1 commit into from
May 17, 2024

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented May 17, 2024

🗣 Description

This PR adds two additional permissions to dns/provisionpublishegressip_policy.tf that are now necessary in order to properly configure the S3 bucket (created in cisagov/publish-egress-ip-terraform) used for publishing egress IPs.

💭 Motivation and context

Without these permissions, we cannot properly configure the egress IP bucket for public read-only access, which is a requirement for cisagov/publish-egress-ip-terraform#6.

🧪 Testing

I applied these changes and verified that I was able to successfully apply the code in cisagov/publish-egress-ip-terraform. All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label May 17, 2024
@dav3r dav3r self-assigned this May 17, 2024
@dav3r dav3r requested a review from a team May 17, 2024 19:04
@dav3r dav3r merged commit 7a62b18 into develop May 17, 2024
5 checks passed
@dav3r dav3r deleted the improvement/add-permissions branch May 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants