Add CloudFront Origin Access Controls permissions to ProvisionPublishEgressIP policy
#145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are needed in order to manage CloudFront Origin Access Controls (OAC).
dav3r
added
the
improvement
dav3r
requested review from
felddy,
jasonodoom,
jsf9k and
mcdonnnj
as code owners
jsf9k
approved these changes
May 28, 2024
dv4harr10
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds CloudFront Origin Access Controls permissions to
dns/provisionpublishegressip_policy.tfthat are needed to properly configure the S3 bucket (created incisagov/publish-egress-ip-terraform) used for publishing egress IPs.💭 Motivation and context
Without these permissions, we cannot properly configure the egress IP bucket to be accessed via CloudFront, which is part of the work in cisagov/publish-egress-ip-terraform#6.
🧪 Testing
I applied these changes and verified that I was able to successfully apply the code in
cisagov/publish-egress-ip-terraform. All automated tests pass.✅ Pre-approval checklist