Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "console_access" user attribute #52

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Dec 20, 2024

🗣 Description

This PR adds a new "console_access" attribute to the users map. If "console_access" is not "true" for a given user, then a login profile will not be created for that user and their console access will be disabled.

💭 Motivation and context

Certain users do not require console access, so this PR gives us the flexibility to do that.

🧪 Testing

I updated a tfvars file to include the new "console_access" attribute, applied the Terraform, and confirmed that the login profiles were deleted for users where "console_access" = false and not for users where "console_access" = true.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Update tfvars files in all environments to include the new console_access user attribute.

If console_access is not "true" for a given IAM user, then a login profile will not be created for that user and their console access will be disabled.
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Dec 20, 2024
@dav3r dav3r requested a review from a team December 20, 2024 15:46
@dav3r dav3r self-assigned this Dec 20, 2024
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎄🕎 ☃️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants