Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Scrapy 2.9.0 => 2.11.0. #2433

Closed
wants to merge 3 commits into from
Closed

Bump Scrapy 2.9.0 => 2.11.0. #2433

wants to merge 3 commits into from

Conversation

Matthew-Grayson
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson commented Dec 24, 2023 •
edited
Loading

🗣 Description

Bump Scrapy from 2.9.0 to 2.11.0
Twisted, a dependency of Scrapy, pushed a recent update that breaks Scrapy compatibility.
Scrapy 2.11.0 pins the version of twisted to th latest version that still works with Scrapy (<23.8.0).

💭 Motivation and context

Fixes webscraper scan
Closes issue #2431

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@Matthew-Grayson Matthew-Grayson linked an issue Dec 24, 2023 that may be closed by this pull request
Webscraper is Broken #2431
Open
@Matthew-Grayson Matthew-Grayson self-assigned this Dec 24, 2023
@Matthew-Grayson Matthew-Grayson added Backend ASM-VDB Technical Infrastructure and Database Dependencies Pull requests that update a dependency file Python Pull requests that update Python code labels Dec 24, 2023
@Matthew-Grayson Matthew-Grayson marked this pull request as ready for review December 24, 2023 03:55
aloftus23
aloftus23 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@aloftus23 aloftus23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👍

@Matthew-Grayson Matthew-Grayson mentioned this pull request Feb 17, 2024
Open
@Matthew-Grayson
Copy link
Contributor Author

Superseded by PR #2542

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aloftus23 aloftus23 aloftus23 approved these changes

@cduhn17 cduhn17 Awaiting requested review from cduhn17 cduhn17 is a code owner

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

Assignees

@Matthew-Grayson Matthew-Grayson

Labels
Backend ASM-VDB Technical Infrastructure and Database Dependencies Pull requests that update a dependency file Python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Webscraper is Broken
2 participants
@Matthew-Grayson @aloftus23