Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create IAM user to enable ELK integration with AWS #2543

Merged
merged 3 commits into from
Feb 15, 2024
Merged

Create IAM user to enable ELK integration with AWS #2543

merged 3 commits into from
Feb 15, 2024

Conversation

aloftus23
Copy link
Contributor

@aloftus23 aloftus23 commented Feb 15, 2024 •
edited
Loading

🗣 Description

fixes #2536

Elk requires an IAM user with the permissions listed on the site below in order to integrate with our AWS account.

https://docs.elastic.co/integrations/aws#requirements

Also adds additional logging and removes unnecessary logic in scanExecution.

🧪 Testing

Passes pre-commit tests and terraform plan review.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

@aloftus23 aloftus23 self-assigned this Feb 15, 2024
@aloftus23 aloftus23 marked this pull request as ready for review February 15, 2024 18:43
cduhn17
cduhn17 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@cduhn17 cduhn17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Matthew-Grayson
Matthew-Grayson approved these changes Feb 15, 2024
View reviewed changes
Copy link
Contributor

@Matthew-Grayson Matthew-Grayson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@aloftus23 aloftus23 merged commit ce7403a into master Feb 15, 2024
15 of 16 checks passed
@aloftus23 aloftus23 deleted the AL-ELK-user branch February 15, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cduhn17 cduhn17 cduhn17 approved these changes

@Matthew-Grayson Matthew-Grayson Matthew-Grayson approved these changes

@rapidray12 rapidray12 Awaiting requested review from rapidray12 rapidray12 is a code owner

@schmelz21 schmelz21 Awaiting requested review from schmelz21 schmelz21 is a code owner

@nickviola nickviola Awaiting requested review from nickviola nickviola is a code owner

Assignees

@aloftus23 aloftus23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create IAM account for ELK integrations
3 participants
@aloftus23 @cduhn17 @Matthew-Grayson