Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bug where autoLoadSupp nulls out #4033

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

mattrwins
Copy link
Contributor

🗣 Description

There's a bug where the AutoLoadSupplemental function needs a modelId from the config.json, but only 2 maturities have the modelId. This fix defaults to the moduleName if the modelId doesn't exist.

💭 Motivation and context

🧪 Testing

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

  • Revert dependencies to default branches.
  • Finalize version.

✅ Post-merge checklist

  • Create a release.

@inlguy inlguy merged commit 343c5fb into develop Aug 28, 2024
2 checks passed
@inlguy inlguy deleted the bug/autoLoadSupp-nulling-out branch August 28, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants