Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update issue ref for Terraforms continued lack of support for module iteration #254

Merged
merged 3 commits into from
Mar 2, 2020
Merged

Update issue ref for Terraforms continued lack of support for module iteration #254

merged 3 commits into from
Mar 2, 2020

Conversation

felddy
Copy link
Member

@felddy felddy commented Feb 26, 2020

🗣 Description

💭 Motivation and Context

Just refreshing brain, and noticed this was OBE.

🧪 Testing

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felddy felddy requested review from jsf9k, dav3r and mcdonnnj February 26, 2020 17:37
@felddy felddy self-assigned this Feb 26, 2020
jsf9k
jsf9k approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circlin' back!

dav3r
dav3r approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid. ⛰

@felddy felddy merged commit 094aad6 into develop Mar 2, 2020
@felddy felddy deleted the improvement/configure_doc_change branch March 2, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@felddy felddy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felddy @jsf9k @dav3r