Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest cisagov/domain scan code #108

Merged
merged 5 commits into from
Nov 29, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 26, 2023

🗣 Description

This pull request modifies this Docker container to use the latest code from cisagov/domain-scan, specifically the changes from cisagov/domain-scan#6.

💭 Motivation and context

This enables us to test cisagov/domain-scan#6 and hence resolve cisagov/domain-scan#7.

🧪 Testing

All automated tests pass. I also built a new Docker image containing these changes and verified that it functioned as expected.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.
  • Build and test a new Docker image containing these changes.

✅ Pre-merge checklist

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number docker Pull requests that update Docker code labels Nov 26, 2023
@jsf9k jsf9k self-assigned this Nov 26, 2023
@jsf9k jsf9k marked this pull request as ready for review November 27, 2023 03:04
@jsf9k jsf9k requested review from a team and felddy November 27, 2023 03:04
@dv4harr10
Copy link
Contributor

Hi Team, In the Description the first link appears to be broken, returns error 'can't reach this page."

@jsf9k
Copy link
Member Author

jsf9k commented Nov 27, 2023

Hi Team, In the Description the first link appears to be broken, returns error 'can't reach this page."

Thanks @dv4harr10. It's now fixed.

Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k enabled auto-merge November 29, 2023 16:08
@jsf9k jsf9k merged commit cb7fd41 into develop Nov 29, 2023
14 checks passed
@jsf9k jsf9k deleted the improvement/use-latest-domain-scan branch November 29, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Get rid of Python warnings about "invalid escape sequence"s
3 participants