Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields from CVSS v3 and VPR updates #33

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented May 13, 2022

🗣 Description

This PR updates the data dictionary to include the new fields that were added in these PRs:

💭 Motivation and context

We strive to keep our documentation up-to-date.

This PR is blocked until cisagov/cyhy-core#69 and cisagov/cyhy-core#70 are deployed.

🧪 Testing

I visually inspected the Markdown preview and everything looks good.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge checklist

@dav3r dav3r added blocked This issue or pull request is awaiting the outcome of another issue or pull request documentation This issue or pull request improves or adds to documentation labels May 13, 2022
@dav3r dav3r requested review from felddy, jsf9k and mcdonnnj as code owners May 13, 2022 20:36
@dav3r dav3r self-assigned this May 13, 2022
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tying up all the loose ends, as usual!

Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way to future-proof this bad boi!
💪

@dav3r dav3r removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 9, 2022
@dav3r dav3r merged commit a5a67d2 into develop Jun 9, 2022
@dav3r dav3r deleted the improvement/support-cvss-v3-and-vpr branch June 9, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This issue or pull request improves or adds to documentation
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants