-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚠️ CONFLICT! Lineage pull request for: skeleton #119
Open
cisagovbot
wants to merge
34
commits into
develop
Choose a base branch
from
lineage/skeleton
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+272
−205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently there is a bug in the script's logic that prevents you from running `./bump-version prerelease` to bump _just_ the prerelease. This is due to faulty checking logic to ensure expected behavior when combining bump commands.
This lets us avoid hardcoding the bucket name and allows it to be set on a per-environment basis via the -backend-config command line option or other methods. For details, see: https://developer.hashicorp.com/terraform/language/backend#partial-configuration
…emote states Also, make all remote states use the same environment (no more mixed staging and production states).
This is the extension I chose for our backend config files.
Also, assume the newly-renamed and environment-specific build role.
Now that we have a suitable dev environment, we want to create AMIs there. Previously, we did not create AMIs until the prerelease workflow was run.
Also, assume the newly-renamed and environment-specific build role.
…ith GitHub Actions
This lets us avoid hardcoding the bucket name and allows it to be set on a per-environment basis via the -backend-config command line option or other methods. For details, see: https://developer.hashicorp.com/terraform/language/backend#partial-configuration
…d accounts This can be done thanks to our new scheme which no longer has staging and production accounts co-mingled in the same AWS organization.
Co-authored-by: Jeremy Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Co-authored-by: mcdonnnj <mcdonnnj@github.com>
Co-authored-by: mcdonnnj <mcdonnnj@github.com>
Co-authored-by: mcdonnnj <mcdonnnj@github.com>
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
…mver-pin Add a comment explaining why we require `semver>=3`
…p_prereleases Ensure the `bump-version` script can bump pre-releases
…dule" This reverts commit 92948c8.
a2d81bc
to
0e28ff9
Compare
I still have to test the AMI that was created in the dev environment, but for now, this PR is ready for review. |
jsf9k
approved these changes
Feb 7, 2025
Co-authored-by: Jeremy Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
jsf9k
approved these changes
Feb 20, 2025
felddy
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for answering my questions in person.
⭐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ansible
Pull requests that update Ansible code
github-actions
Pull requests that update GitHub Actions code
packer
Pull requests that update Packer code
upstream update
This issue or pull request pulls in upstream updates
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-packer.git
Remote branch:
HEAD
Check the changes in this pull request to ensure they won't cause issues with
your project.
The
lineage/skeleton
branch has one or more unresolved merge conflictsthat you must resolve before merging this pull request!
How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
status
command. Fix any conflicts andpossibly incorrect auto-merges.
After resolving each of the conflicts,
add
your changes to thebranch,
commit
, andpush
your changes:Note that you may append to the default merge commit message
that git creates for you, but please do not delete the existing
content. It provides useful information about the merge that is
being performed.
Wait for all the automated tests to pass.
Confirm each item in the "Pre-approval checklist" below.
Remove any of the checklist items that do not apply.
Ensure every remaining checkbox has been checked.
Mark this draft pull request "Ready for review".
✅ Pre-approval checklist
Remove any of the following that do not apply. If you're unsure about
any of these, don't hesitate to ask. We're here to help!
to reflect the changes in this PR.
✅ Testing checklist
✅ Pre-merge checklist
build
version for dev and staging test builds.build
version again for final production (release) build.✅ Post-merge checklist
Remove any of the following that do not apply.
Note
You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml
📚 Read more about Lineage