Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ CONFLICT! Lineage pull request for: skeleton #119

Open
wants to merge 34 commits into
base: develop
Choose a base branch
from

Conversation

cisagovbot
Copy link

@cisagovbot cisagovbot commented Jan 24, 2025

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-packer.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.

The lineage/skeleton branch has one or more unresolved merge conflicts
that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/openvpn-packer.git openvpn-packer
    cd openvpn-packer
    git remote add skeleton https://github.com/cisagov/skeleton-packer.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and
    possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the
    branch, commit, and push your changes:

    git add .github/workflows/build.yml .github/workflows/prerelease.yml .github/workflows/release.yml README.md ami_arm64.pkr.hcl ami_x86_64.pkr.hcl terraform-post-packer/main.tf version.txt 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message
    that git creates for you, but please do not delete the existing
    content
    . It provides useful information about the merge that is
    being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

Remove any of the following that do not apply. If you're unsure about
any of these, don't hesitate to ask. We're here to help!

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

✅ Testing checklist

  • Validate that the AMI created by this PR functions correctly in Dev
  • Validate that the AMI created by this PR functions correctly in Staging

✅ Pre-merge checklist

  • Bump build version for dev and staging test builds.
  • Bump build version again for final production (release) build.

✅ Post-merge checklist

Remove any of the following that do not apply.

  • Create a release.

Note

You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 30 commits January 6, 2025 15:12
Currently there is a bug in the script's logic that prevents you from
running `./bump-version prerelease` to bump _just_ the prerelease. This
is due to faulty checking logic to ensure expected behavior when
combining bump commands.
This lets us avoid hardcoding the bucket name and allows it to be set on a per-environment basis via the -backend-config command line option or other methods.  For details, see: https://developer.hashicorp.com/terraform/language/backend#partial-configuration
…emote states

Also, make all remote states use the same environment (no more mixed staging and production states).
This is the extension I chose for our backend config files.
Also, assume the newly-renamed and environment-specific build role.
Now that we have a suitable dev environment, we want to create AMIs there.  Previously, we did not create AMIs until the prerelease workflow was run.
Also, assume the newly-renamed and environment-specific build role.
This lets us avoid hardcoding the bucket name and allows it to be set on a per-environment basis via the -backend-config command line option or other methods.  For details, see: https://developer.hashicorp.com/terraform/language/backend#partial-configuration
…d accounts

This can be done thanks to our new scheme which no longer has staging and production accounts co-mingled in the same AWS organization.
Co-authored-by: Jeremy Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Co-authored-by: mcdonnnj <mcdonnnj@github.com>
Co-authored-by: mcdonnnj <mcdonnnj@github.com>
Co-authored-by: mcdonnnj <mcdonnnj@github.com>
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
…mver-pin

Add a comment explaining why we require `semver>=3`
…p_prereleases

Ensure the `bump-version` script can bump pre-releases
@dav3r dav3r added github-actions Pull requests that update GitHub Actions code ansible Pull requests that update Ansible code packer Pull requests that update Packer code labels Feb 6, 2025
@dav3r
Copy link
Member

dav3r commented Feb 6, 2025

I still have to test the AMI that was created in the dev environment, but for now, this PR is ready for review.

@dav3r dav3r marked this pull request as ready for review February 6, 2025 23:28
Co-authored-by: Jeremy Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for answering my questions in person.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Pull requests that update Ansible code github-actions Pull requests that update GitHub Actions code packer Pull requests that update Packer code upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants