Skip to content
This repository has been archived by the owner on Feb 14, 2024. It is now read-only.

Rename duplicate modules #581

Closed
wants to merge 1 commit into from
Closed

Conversation

aeferguson-23
Copy link

@aeferguson-23 aeferguson-23 commented Jun 5, 2023

fixes #578

🗣 Description

Renaming shodan.py to pe_shodan.py and editing the affected module imports.
Also added a check for fields in API list in pe_shodan.py to eliminate failure upon empty list.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but you added some unnecessary whitespace in a few places.

@@ -24,7 +23,7 @@ def run_shodan(self):

# Get orgs from PE database
pe_orgs = get_orgs()

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

class Shodan:
"""Fetch Shodan data."""

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@dav3r
Copy link
Member

dav3r commented Jun 8, 2023

Please let us know when all of the tests are passing, then I will be happy to review this.

@aloftus23 aloftus23 changed the base branch from staging to develop June 16, 2023 15:34
@aloftus23 aloftus23 requested a review from jasonodoom as a code owner June 16, 2023 15:34
@aloftus23 aloftus23 changed the base branch from develop to staging June 16, 2023 15:35
@aeferguson-23 aeferguson-23 deleted the AF-optimize-shodan-staging branch June 16, 2023 17:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants