DRY out hook functionality #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a utility library to handle argument processing since it is used by both hooks. Also put the logic for getting unique directory paths there since it makes sense to put that kind of functionality in a utility library.
mcdonnnj
added
the
improvement
dv4harr10
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request breaks duplicated hook logic out into a separate library that is imported. Since it's another potentially general piece of functionality the unique path logic is also moved into the utility library.
💭 Motivation and context
It's best to break out duplicated or general code when possible to reduce conflicting duplication and effort.
🧪 Testing
Automated tests pass. I tested it locally and the hooks functioned as expected.
✅ Pre-approval checklist