Enhance the bump_version.sh script
#43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the script to allow you to simultaneously bump the prerelease with the major, minor, or patch versions; de-duplicates logic for modifying and committing files; allows you to set the label used when bumping the build or prerelease versions; and makes performing a `git push` an optional flag.
Adjust the usage information to document some new options, make the command name in the usage based on the file name for the script, and add explicit help flags.
This treats this script like the `setup-env` script already present.
mcdonnnj
added
breaking change
jsf9k
approved these changes
Sep 24, 2024
dav3r
approved these changes
Sep 24, 2024
A reference in the script was not updated when the script had its name changed. Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
dv4harr10
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request does the following:
bump_version.shscript tobump-version.bump-versionscript to provide more functionality, including:0.0.1to0.1.0-rc.1in one command for example.git pushopt-in as an option.0.0.1+dev.1or a0.1.0-alpha.1with the script.💭 Motivation and context
I have wanted to update this script to remove some of the pain points I have with it such as having to run it twice to generate a prerelease of a new version. This seemed like as good a time as any to do so.
🧪 Testing
Automated tests pass. I used it to update the version in this pull request. I then used the prerelease version I published from this branch in my modified local cisagov/cyhy_amis and cisagov/skeleton-packer repositories and confirmed things work as expected from previously merged pull requests.
✅ Pre-approval checklist
to reflect the changes in this PR.
✅ Pre-merge checklist
✅ Post-merge checklist