-
Notifications
You must be signed in to change notification settings - Fork 2
⚠️ CONFLICT! Lineage pull request for: skeleton #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
This commit will make a few changes. The orginal version of the semantic checking function was a bit more difficult to read. It is now somewhat easier to follow how the regex is structured. Also the function has been renamed to check_python_version since it has 2 functions, making sure that the version is semantically correct and the second is to make sure that it is installed on the user's machine. This makes it easier to follow the logic for the flags, -p or --python-version and -l or --list-versions
…ttps://github.com/cisagov/skeleton-generic into improvement/correct-semantic-python-version-checks
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Co-authored-by: dav3r <david.redmin@trio.dhs.gov>
Add the `check-useless-excludes` meta hook to verify that any defined `exclude` directives apply to at least one file in the repository.
New versions of ansible-core (2.16.7 and 2.17.0) have been released that do not suffer from the bug discussed in ansible/ansible#82702. This bug broke any symlinked files in vars, tasks, etc. for any Ansible role installed via ansible-galaxy. All versions later than ansible-core 2.16.7 and 2.17.0 should function as expected. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
The line is not only unnecessary, it was commented out to boot!
…lint On its own ansible-lint does not pull in ansible, only ansible-core. Therefore, if an Ansible module lives in ansible instead of ansible-core, the linter will complain that the module is unknown. In these cases it is necessary to add the ansible package itself as an additional dependency, with the same pinning as is done in requirements-test.txt of cisagov/skeleton-ansible-role.
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier was manually held back because the latest tags are for alpha releases of the next major version.
Use the latest v3 release available from NPM.
The pin now agrees with what is in cisagov/skeleton-ansible-role. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Update `pre-commit` hooks
…ible-lint Pin packages for `ansible-lint`
Instead of manually installing Packer we can instead leverage the hashicorp/setup-packer Action just as we do for Terraform.
He is no longer a member of @cisagov/vm-dev.
Previously we only provided a lower bound for the version, but pinning to a specific version aligns with what has been done with the prettier hook and how pre-commit hooks are pinned in general. The flake8-docstrings package is rarely updated, so there is no real downside to pinning to a specific version. Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [crazy-max/ghaction-github-status](https://github.com/crazy-max/ghaction-github-status) from 3 to 4. - [Release notes](https://github.com/crazy-max/ghaction-github-status/releases) - [Commits](crazy-max/ghaction-github-status@v3...v4) --- updated-dependencies: - dependency-name: crazy-max/ghaction-github-status dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
This is done automatically with the `pre-commit autoupdate` command. The pre-commit/mirrors-prettier hook was manually held back because the latest tags are for alpha releases of the next major version.
Use the latest v3 release available from NPM.
We use the bandit pre-commit hook twice in this configuration and only one of the configurations is updated automatically from upstream. Therefore, we must manually update the second configuration to keep the versions in sync.
Update the `test` and `build` jobs to also use the cisagov/action-job-preamble action.
Remove the `bump_version.sh` script as it has been superceded by the `bump-version` script, remove the version.txt inherited from upstream, update the `bump-version` script to modify the correct version-tracking file, and update the src/version.txt file to match the updated format for version-tracking files that are not imported into code.
e7fdafc
to
3139873
Compare
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
This is necessary to have a valid artifact name for upload.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
…sible-lint Upgrade to the latest version of the `ansible-lint` `pre-commit` hook
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This lineage pull request incorporates upstream changes from the skeleton-generic repository to align the project with the latest standards and best practices. The changes focus on modernizing development tooling, improving workflow configurations, and enhancing version management capabilities.
Key Changes:
- Replaced the legacy
bump_version.sh
script with a more robustbump-version
script that provides enhanced version management features - Updated GitHub Actions workflows to use standardized job preambles and improved security practices
- Modernized development dependencies and configuration files with updated versions and improved linting rules
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
bump_version.sh |
Removed legacy version bumping script |
bump-version |
Added new comprehensive version management script with enhanced functionality |
setup-env |
Enhanced Python version validation with semantic versioning support |
requirements-dev.txt |
Updated semver dependency with version constraint and documentation |
src/version.txt |
Simplified version format from Python assignment to plain version string |
tests/test_version.py |
Removed shebang line from test file |
.github/workflows/build.yml |
Updated to use standardized job preamble and improved caching |
.github/workflows/codeql-analysis.yml |
Modernized security scanning workflow configuration |
.github/workflows/sync-labels.yml |
Updated label synchronization workflow |
.github/workflows/dependency-review.yml |
Added new dependency review workflow for security |
.pre-commit-config.yaml |
Updated hook versions and added new security checks |
.yamllint |
Enhanced YAML linting rules for better Ansible compatibility |
.mdl_config.yaml |
Updated markdown linting configuration |
docker-compose.yml |
Standardized YAML formatting |
.github/lineage.yml |
Updated YAML formatting |
.github/labels.yml |
Standardized label color formatting |
.github/dependabot.yml |
Updated dependency management configuration |
.github/CODEOWNERS |
Updated code ownership assignments |
# Start of the prerelease | ||
local prerelease="(?:-" | ||
# Numeric or alphanumeric identifiers | ||
local prerelease+="(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string concatenation using += operator is not portable across all shell implementations. Consider using explicit concatenation or a different approach for better compatibility.
Copilot uses AI. Check for mistakes.
local prerelease+="(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" | ||
# Additional dot-separated identifiers | ||
local prerelease+="(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*" | ||
# End of the prerelease, making it optional | ||
local prerelease+=")?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string concatenation using += operator is not portable across all shell implementations. Consider using explicit concatenation or a different approach for better compatibility.
local prerelease+="(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" | |
# Additional dot-separated identifiers | |
local prerelease+="(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*" | |
# End of the prerelease, making it optional | |
local prerelease+=")?" | |
prerelease="${prerelease}(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" | |
# Additional dot-separated identifiers | |
prerelease="${prerelease}(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*" | |
# End of the prerelease, making it optional | |
prerelease="${prerelease})?" |
Copilot uses AI. Check for mistakes.
local prerelease+="(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" | ||
# Additional dot-separated identifiers | ||
local prerelease+="(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*" | ||
# End of the prerelease, making it optional | ||
local prerelease+=")?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The string concatenation using += operator is not portable across all shell implementations. Consider using explicit concatenation or a different approach for better compatibility.
local prerelease+="(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" | |
# Additional dot-separated identifiers | |
local prerelease+="(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*" | |
# End of the prerelease, making it optional | |
local prerelease+=")?" | |
prerelease="${prerelease}(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*)" | |
# Additional dot-separated identifiers | |
prerelease="${prerelease}(?:\.(?:0|[1-9]\d*|\d*[a-zA-Z-][0-9a-zA-Z-]*))*" | |
# End of the prerelease, making it optional | |
prerelease="${prerelease})?" |
Copilot uses AI. Check for mistakes.
Lineage Pull Request: CONFLICT
Lineage has created this pull request to incorporate new changes found in an
upstream repository:
Upstream repository:
https://github.com/cisagov/skeleton-generic.git
Remote branch:
HEAD
Check the changes in this pull request to ensure they won't cause issues with
your project.
The
lineage/skeleton
branch has one or more unresolved merge conflictsthat you must resolve before merging this pull request!
How to resolve the conflicts
Take ownership of this pull request by removing any other assignees.
Clone the repository locally, and reapply the merge:
Review the changes displayed by the
status
command. Fix any conflicts andpossibly incorrect auto-merges.
After resolving each of the conflicts,
add
your changes to thebranch,
commit
, andpush
your changes:Note that you may append to the default merge commit message
that git creates for you, but please do not delete the existing
content. It provides useful information about the merge that is
being performed.
Wait for all the automated tests to pass.
Confirm each item in the "Pre-approval checklist" below.
Remove any of the checklist items that do not apply.
Ensure every remaining checkbox has been checked.
Mark this draft pull request "Ready for review".
✅ Pre-approval checklist
Note
You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.
For more information:
🛠 Lineage configurations for this project are stored in
.github/lineage.yml
📚 Read more about Lineage