Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit Hook Versions #44

Merged
merged 8 commits into from
May 14, 2020
Merged

Update pre-commit Hook Versions #44

merged 8 commits into from
May 14, 2020

Commits on May 8, 2020

  1. Updated pre-commit configuration with 'pre-commit autoupdate'.

    @mcdonnnj
    mcdonnnj committed May 8, 2020
    Configuration menu
    Copy the full SHA
    7d7a677 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2020

  1. Update isort pre-commit hook source repository. 

    The mirrors-isort respository has been deprecated per this Pull Request:
pre-commit/mirrors-isort#13
Since isort includes pre-commit configuration in current versions we will
switch to using it directly.
    @mcdonnnj
    mcdonnnj committed May 13, 2020
    Configuration menu
    Copy the full SHA
    ce6658a View commit details
    Browse the repository at this point in the history

  2. Ran pre-commit autoupdate.

    @mcdonnnj
    mcdonnnj committed May 13, 2020
    Configuration menu
    Copy the full SHA
    daaebc1 View commit details
    Browse the repository at this point in the history

  3. Remove legacy comment from the isort hook declaration. 

    This comment references the mirrors-isort repository that we are no longer
using.
    @mcdonnnj
    mcdonnnj committed May 13, 2020
    Configuration menu
    Copy the full SHA
    2399f24 View commit details
    Browse the repository at this point in the history

  4. Disable the terraform_validate hook. 

    We have seen a number of issues related to this hook ever since it was
re-enabled. It will need to remain disabled until at least the 0.13 Terraform
release, and can only be re-enabled if all issues we have seen have been
resolved in how `terraform validate` operates.
    @mcdonnnj
    mcdonnnj committed May 13, 2020
    Configuration menu
    Copy the full SHA
    fe4d5eb View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into improvements/pre-commit_autoupdate_2020-05

    @mcdonnnj
    mcdonnnj authored May 13, 2020
    Configuration menu
    Copy the full SHA
    4d4db07 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2020

  1. Add final statement to descriptionf or why terraform_validate is disa… 

    …bled.

Review noticed that there lacked a determination for what we were doing about
the problem with the terraform_validate hook. I described the problems but
failed to mention what our path forward would be. This commit rectifies that
oversight.
    @mcdonnnj
    mcdonnnj committed May 14, 2020
    Configuration menu
    Copy the full SHA
    f831ef8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'improvements/pre-commit_autoupdate_2020-05' of github.c… 

    …om:cisagov/skeleton-generic into improvements/pre-commit_autoupdate_2020-05
    @mcdonnnj
    mcdonnnj committed May 14, 2020
    Configuration menu
    Copy the full SHA
    64edcc2 View commit details
    Browse the repository at this point in the history