Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing Terraform moved blocks once they are no longer needed #369

Open
jsf9k opened this issue Aug 9, 2024 · 0 comments
Open

Consider removing Terraform moved blocks once they are no longer needed #369

jsf9k opened this issue Aug 9, 2024 · 0 comments
Labels
terraform Pull requests that update Terraform code

Comments

@jsf9k
Copy link
Member

jsf9k commented Aug 9, 2024

💡 Summary

@mcdonnnj suggested removing the Terraform moved blocks introduced in #355.

Motivation and context

I personally think the moved blocks can be left in, but you can enjoy my back-and-forth with @mcdonnnj here.
@jsf9k jsf9k added the terraform Pull requests that update Terraform code label Aug 9, 2024
jsf9k added a commit that referenced this issue Aug 9, 2024
@jsf9k
Add comments to moved blocks to explain the intent
bd80fc7 
Also reference issue #369 to consider removing
the moved blocks when they are no longer necessary.
@jsf9k jsf9k mentioned this issue Aug 9, 2024
Merged
11 tasks
jsf9k added a commit that referenced this issue Aug 12, 2024
@jsf9k
Add comments to moved blocks to explain the intent
51944d0 
Also reference issue #369 to consider removing
the moved blocks when they are no longer necessary.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
terraform Pull requests that update Terraform code
Projects
Skeleton Maintenance
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jsf9k