Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable the GitHubSecurityLab/actions-permissions/monitor action #98

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Re-enable the GitHubSecurityLab/actions-permissions/monitor action #98

merged 1 commit into from
Dec 20, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 20, 2024 •
edited
Loading

🗣 Description

This pull request re-enables the GitHubSecurityLab/actions-permissions/monitor action.

💭 Motivation and context

With the merge of GitHubSecurityLab/actions-permissions#34, this proxy no longer interferes with AWS API or boto3 calls.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
Re-enable the GitHubSecurityLab/actions-permissions/monitor action
b955f26 
With the merge of GitHubSecurityLab/actions-permissions#34, this proxy
no longer interferes with AWS API or boto3 calls.
@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use github-actions Pull requests that update GitHub Actions code security This issue or pull request addresses a security issue labels Dec 20, 2024
@jsf9k jsf9k self-assigned this Dec 20, 2024
@jsf9k jsf9k requested a review from a team December 20, 2024 17:52
@jsf9k jsf9k enabled auto-merge December 20, 2024 17:52
@jsf9k jsf9k merged commit 39c70d9 into develop Dec 20, 2024
8 checks passed
@jsf9k jsf9k deleted the improvement/re-enable-permissions-proxy branch December 20, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@mcdonnnj mcdonnnj Awaiting requested review from mcdonnnj mcdonnnj is a code owner

Assignees

@jsf9k jsf9k

Labels
github-actions Pull requests that update GitHub Actions code improvement This issue or pull request will add or improve functionality, maintainability, or ease of use security This issue or pull request addresses a security issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsf9k @dav3r @dv4harr10