Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDOMAIN exceptions now signal that the domain is "not live" #67

Merged

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Feb 27, 2018

This resolves #66.

@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Feb 27, 2018
@jsf9k jsf9k self-assigned this Feb 27, 2018
@jsf9k jsf9k requested review from h-m-f-t and dav3r February 27, 2018 15:02
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jsf9k jsf9k merged commit c1e1450 into develop Feb 27, 2018
@jsf9k jsf9k deleted the bugfix/nxdomain_exception_should_signal_that_domain_is_not_live branch February 27, 2018 19:36
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
…it_hook

Add the beautysh pre-commit hook
mcdonnnj added a commit that referenced this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Domains that throw an NXDOMAIN exception should be treated as "not live"
3 participants