Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of Python 3.11 #112

Merged
merged 4 commits into from
Oct 19, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 18, 2023

🗣 Description

This pull request upgrades the Dockerfile to use the latest version of Python 3.11.

💭 Motivation and context

We can't upgrade to Python 3.12 right now because matplotlib uses configparser.SafeConfigParser, but as of Python 3.12 that object has been removed from the configparser library. Hence we are stuck at 3.11 until we can upgrade matplotlib.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

✅ Post-merge checklist

  • Create a release.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number docker Pull requests that update Docker code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation labels Oct 18, 2023
@jsf9k jsf9k self-assigned this Oct 18, 2023
@jsf9k jsf9k removed the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Oct 18, 2023
We can't upgrade to Python 3.12 right now because matplotlib uses
configparser.SafeConfigParser, but as of Python 3.12 that object has
been removed from the configparser library. Hence we are stuck at 3.11
until we can upgrade matplotlib.

For more information:
https://github.com/python/cpython/blob/3.12/Lib/configparser.py
The installation of cmake appears to now be required to build some of
the pip dependencies that get pulled in (particularly ninja).
The installation of numpy appears to now require the BLAS and LAPACK
libraries.
@jsf9k jsf9k marked this pull request as ready for review October 19, 2023 13:27
@jsf9k jsf9k enabled auto-merge October 19, 2023 13:28
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k requested review from felddy and a team October 19, 2023 20:21
@jsf9k jsf9k merged commit d15058b into develop Oct 19, 2023
14 checks passed
@jsf9k jsf9k deleted the improvement/upgrade-python branch October 19, 2023 21:11
@jsf9k jsf9k mentioned this pull request Nov 26, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docker Pull requests that update Docker code hacktoberfest-accepted Pull request that should count toward Hacktoberfest participation version bump This issue or pull request increments the version number
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants