Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow for deployment of vmanages with cluster subnet configured on AWS #24

Merged
merged 1 commit into from
Oct 23, 2024
Merged

allow for deployment of vmanages with cluster subnet configured on AWS #24

merged 1 commit into from
Oct 23, 2024

Conversation

przsus
Copy link
Contributor

@przsus przsus commented Oct 22, 2024

Pull Request summary:

allow for deployment of vmanages with cluster subnet configured on AWS

Description of changes:

  • deployment of vmanages with eth2 intf for cluster communication
  • setting security group rules in a way that allows for cluster communication
  • updating vmanage template to create eth2 for cluster config
  • conditionally setting aws_subnets to include cluster subnet based on total num of configured vmanages

Checklist:

  • PR description is clear and comprehensive
  • Mentioned the issue that this PR solves (if applicable)
  • Make sure you test the changes

@przsus przsus requested a review from cicharka October 22, 2024 11:13
cicharka
cicharka approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@cicharka cicharka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@przsus przsus merged commit 964ce8b into main Oct 23, 2024
5 checks passed
@przsus przsus deleted the fr/cluster_updated branch October 23, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cicharka cicharka cicharka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@przsus @cicharka