Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate glide, use Go modules #47

Merged
merged 8 commits into from
May 30, 2019
Merged

Deprecate glide, use Go modules #47

merged 8 commits into from
May 30, 2019

Conversation

remingtonc
Copy link
Contributor

@remingtonc remingtonc commented May 30, 2019

Removes glide related files, replaces with generated go.mod based off of them, and removes vendor/ directory. Test by cloning this repository out of your $GOPATH.

Resolves #5

Squash merge.

Copy link
Collaborator

@BenderScript BenderScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Travis looks sane.

@BenderScript BenderScript merged commit f6df264 into master May 30, 2019
@remingtonc remingtonc deleted the go-mod branch May 30, 2019 21:12
remingtonc pushed a commit that referenced this pull request May 30, 2019
Deprecate glide, use Go modules
Copy link
Collaborator

@nleiva nleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ergonomics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Go modules
3 participants