Skip to content

Commit

Permalink
small cleanup (#4)
Browse files Browse the repository at this point in the history
Deprecated linters are removed from the golangci config file. README
file is updated slightly.
  • Loading branch information
myungjin authored Oct 8, 2021
1 parent fa461ed commit d3962a5
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 13 deletions.
10 changes: 1 addition & 9 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ linters:
- dogsled
- dupl
- exhaustive
- exportloopref
- funlen
- goconst
- gocyclo
Expand All @@ -82,13 +83,11 @@ linters:
- goprintffuncname
- govet
- ineffassign
- interfacer
- lll
- misspell
- nakedret
- nolintlint
- rowserrcheck
- scopelint
- staticcheck
- structcheck
- typecheck
Expand Down Expand Up @@ -124,13 +123,6 @@ issues:
- gocritic
text: "unnecessaryDefer:"

# TODO temporary rule, must be removed
# seems related to v0.34.1, but I was not able to reproduce locally,
# I was also not able to reproduce in the CI of a fork,
# only the golangci-lint CI seems to be affected by this invalid analysis.
- path: pkg/golinters/scopelint.go
text: 'directive `//nolint:interfacer` is unused for linter interfacer'

run:
skip-dirs:
- test/testdata_etc
Expand Down
9 changes: 5 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,15 @@ while a python library facilitates composition of ML workloads.

## Development setup

Development has been mainly conducted under macOS environment. For now, this section describes how to set up
a development environment in macOS.
The target runtime environment is Linux. Development has been mainly conducted under macOS environment.
For now, this section describes how to set up a development environment in macOS.

The tested version for golang is 1.16+ and the tested version for python is 3.8+.

```
brew install go
brew install golangci-lint
git clone git@wwwin-github.cisco.com:eti/fledge.git
git clone git@github.com:cisco/fledge.git
```

### To compile locally
Expand All @@ -28,5 +28,6 @@ make local
### To run a linter
```
cd fledge
./lint.sh
go get ./...
golangci-lint run -v
```

0 comments on commit d3962a5

Please sign in to comment.