Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version check run as best effort #197

Merged

Conversation

pavel-georgiev
Copy link
Contributor

Description

  • Do not hold command execution in order to wait on the version check to complete. If it does not complete in time, we will try again next time. This makes it a no-cost operation for local commands, while allows it to still succeedes when fsoc is doing network commands (which take longer than the version check)
  • When a version check completes successfully, store the version in a file
  • Report a new version on each fsoc command, unless version check is disabled

@codecov-commenter
Copy link

Codecov Report

Merging #197 (d86b858) into main (16a0b8d) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   29.34%   29.34%           
=======================================
  Files          30       30           
  Lines        3974     3974           
=======================================
  Hits         1166     1166           
  Misses       2721     2721           
  Partials       87       87           

pnickolov
pnickolov previously approved these changes Sep 2, 2023
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
@pnickolov pnickolov merged commit 53fb429 into cisco-open:main Sep 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants