Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smart agent blocker not detected, add burstable blocker support #277

Conversation

linkous8
Copy link
Contributor

@linkous8 linkous8 commented Feb 8, 2024

Description

  • Fix: Configure command was able to onboard hard blocker "missing orchestration agent" without passing hard override flag
  • Add support for the burstable instance blocker (eg. for AWS T instances)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba840f9) 26.88% compared to head (39170d9) 26.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #277   +/-   ##
=======================================
  Coverage   26.88%   26.88%           
=======================================
  Files          44       44           
  Lines        4564     4564           
=======================================
  Hits         1227     1227           
  Misses       3242     3242           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov pnickolov merged commit 749463f into cisco-open:main Feb 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants