Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactored manifest creation, added checks #281

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

pnickolov
Copy link
Contributor

Description

Refactored the function that creates an initial solution manifest to allow for extensible options. This has no user-visible impact, just provides for extensibility, such as adding info for application and module solution types.

Added warnings in case the solution type and the manifest version provided on creation of the manifest don't match the currently supported ones. This should be an error but we don't want to prevent testing of new versions of manifest and/or solution types should they come up.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9db7d4a) 26.88% compared to head (fff7ea8) 26.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #281   +/-   ##
=======================================
  Coverage   26.88%   26.88%           
=======================================
  Files          44       44           
  Lines        4564     4564           
=======================================
  Hits         1227     1227           
  Misses       3242     3242           
  Partials       95       95           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pnickolov pnickolov merged commit c9eed7b into main Feb 15, 2024
6 checks passed
@pnickolov pnickolov deleted the pn/solution-manifest-improvements branch February 15, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants