Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix exit code on failed solution validation (fsoc-116) #37

Merged
merged 1 commit into from
Mar 3, 2023
Merged

fix exit code on failed solution validation (fsoc-116) #37

merged 1 commit into from
Mar 3, 2023

Conversation

pnickolov
Copy link
Contributor

Description

Fixed exit code for solution validate so that non-zero exit code is returned if validation has failed (due to one or more errors reported by the backend)

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@pnickolov pnickolov merged commit e2b2fa3 into main Mar 3, 2023
@pnickolov pnickolov deleted the pnickolov/fix-validate-exit branch March 3, 2023 23:35
GDW1 pushed a commit to GDW1/fsoc that referenced this pull request Mar 4, 2023
@pnickolov
fix exit code on failed solution validation (fsoc-116) (cisco-open#37)
5f2702a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pnickolov