-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failure to update key after mki failure #710
Comments
Scenario logs:
|
pbodilis
pushed a commit
to pbodilis/libsrtp
that referenced
this issue
May 2, 2024
Thanks for reporting this, there was always a chance changing the API would break something but I think have a consistent public API is worth it. I have approved the PR but I also found another occurrence of this issue. I plan to add a test for this, so will get this issue open until the test is added. |
alright, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a receiver, I fail to update srtp keys with MKI using the srtp_stream_update
This is new to master, this works fine with version 2.6.0
scenario:
I suspect the bug to be around
update_template_stream_cb
orsrtp_stream_remove
.srtp_unprotect
creates a new stream withsrtp_stream_clone
, ssrc is stored in network orderbut then,
srtp_strp_remove
expect ssrc to be given in host orderso possible fix can be to replace the call in
update_template_stream_cb
to be consistent with the changes made in the API:data->status = srtp_stream_remove(session, ntohl(ssrc));
PR: #711
The text was updated successfully, but these errors were encountered: