Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider merging the gcm encrypt and get tag functions of cipher api #714

Closed
pabuhler opened this issue May 26, 2024 · 0 comments
Closed

consider merging the gcm encrypt and get tag functions of cipher api #714

pabuhler opened this issue May 26, 2024 · 0 comments

Comments

@pabuhler
Copy link
Member

The gcm encryption is a one shot function, it is always only called only once. The tag is often generated at this point by the underling crypto engine (see aes_gcm_nss.c), it would be clear to append the tag to the out immediately instead of caching it. This would match the decrypt function.
@pabuhler pabuhler mentioned this issue May 26, 2024
Merged
4 tasks
pabuhler added a commit to pabuhler/libsrtp that referenced this issue Jun 11, 2024
@pabuhler
explicitly check dst len is >= tag size
703f2e9 
This is a safety check to ensure we do not wrap dst len when removing tag size.
All of this code would get much cleaner if the tag could just be returned instead of cached. see cisco#714
@pabuhler pabuhler mentioned this issue Jun 26, 2024
Merged
@pabuhler pabuhler closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pabuhler