Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UWP build #513

Merged
merged 2 commits into from
Nov 20, 2020
Merged

Fix UWP build #513

merged 2 commits into from
Nov 20, 2020

Conversation

hanseuljun
Copy link
Contributor

UWP, an application framework from Microsoft for Windows, aims higher in terms of security. And as a result, unfortunately, they thought of turning warnings into errors and introducing some safer functions that are not portable.

This pull request removes two obstacles in front of building the current version in UWP

  1. UWP finds usage of uninitialized local pointers as evil, reporting errors upon them. This is quite reasonable and has an easy fix of initializing the pointers as NULL, so I've done this to about three of them.
  2. UWP thinks using sscanf is wrong and suggests using sscanf_s intsead, which I would not agree if I am in charge of maintaining a portable library. Defining _CRT_SECURE_NO_WARNINGS tells UWP to stop talk about this, so I have added this definition. I added it as a public one of srtp2, so it can spread through the project.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants