Remove dead code #531
Remove dead code #531
Conversation
crypto/include/auth.h
Outdated
| */ | ||
| srtp_err_status_t srtp_replace_auth_type(const srtp_auth_type_t *ct, | ||
| srtp_auth_type_id_t id); | ||
|
|
There was a problem hiding this comment.
The replace functions are API, not dead code - they're to allow a third-party crypto implementation to be injected.
There was a problem hiding this comment.
That's a little surprising to me; I didn't realize the crypto/include headers were considered public API.
There was a problem hiding this comment.
Just crypto/include/cipher.h, crypto/include/auth.h, and crypto/include/crypto_types.h are public - see the install targets in Makefile.in or CMakeLists.txt.
crypto/math/datatypes.c
Outdated
| @@ -302,19 +277,14 @@ void v128_left_shift(v128_t *x, int shift) | |||
|
|
|||
| int bitvector_get_bit(const bitvector_t *v, int bit_index) | |||
| { | |||
| return _bitvector_get_bit(v, bit_index); | |||
| return /bitvector_get_bit(v, bit_index); | |||
There was a problem hiding this comment.
It does, but only because it's within #ifndef DATATYPES_USE_MACROS, and that doesn't appear to be the case for either my local build (macOS, CMake, default config) or any of the CI builds. Maybe we should remove that option?
There was a problem hiding this comment.
DATATYPES_USE_MACROS is defined unconditionally in datatypes.h, so yeah, removing its #ifndef conditions is probably a good idea.
|
@bifurcation could you fix the clang format errors |
|
@pabuhler Looks like all builds are passing now except for the broken mips/meson build. |
As I was looking into migrating things to Rust, I noticed there are a few chunks of around. In addition to the ones I noticed in the SHA-1 code, I scanned for
#if 0blocks and usedcflow -rto find unused functions.