remove use of pointers to 32bit values #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to use pointers to 32bit values, all operations are based on bytes. So This removes alot of extra casting and potential pointer arithmetic errors. Also provide some functions for calculating header values to reduce duplication and improve readability.
pabuhler
force-pushed
the
remove-32bit-pointers
branch
from
6c2b8fb
to
8f10fac
Compare
| #define octets_in_rtp_extn_hdr 4 | ||
| #define octets_in_rtp_xtn_hdr 4 | ||
|
|
||
| static uint32_t srtp_get_rtp_hdr_len(const srtp_hdr_t *hdr) |
There was a problem hiding this comment.
I don't think it's semantically right to use uint32_t for byte lengths? I'd suggest size_t. (Not that this matters practically.)
There was a problem hiding this comment.
I totally agree and plan to convert to size_t both in the public API and internally, at the moment the mix of size_t, uint32_t, int and unsigned int is just staggering in this project. But such a change in the public API needs a major version bump which is why I have been putting it off. I think it might be a goal for the Christmass break to start.
paulej
reviewed
Dec 19, 2023
srtp_get_rtp_xtn_hdr & srtp_get_rtp_xtn_hdr_len both assume that the caller has verified that the input arguments are valid, ie that there is an extension present by previously checking the x bit of the RTP header.
paulej
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no reason to use pointers to 32bit values, all operations are based on bytes. So This removes alot of extra casting and potential pointer arithmetic errors.
Also provide some functions for calculating header values to reduce duplication and improve readability.