Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsitent ToStringConverter Behaviour #173

Closed
p-a-s-c-a-l opened this issue Jun 24, 2016 · 1 comment
Closed

Inconsitent ToStringConverter Behaviour #173

p-a-s-c-a-l opened this issue Jun 24, 2016 · 1 comment
Labels
bug question

Comments

@p-a-s-c-a-l
Copy link
Member

Creation and usage of ToStringConverter in Attribute.class and ObjectAttribute.class is inconsistent and not comprehensible:

  • public ToStringConverter getToStringConverter() in ObjectAttribute modifies class variable
  • toString() in ObjectAttribute always creates a new ToStringConverter instance (ignores not-null toStringConverter class variable!)
  • unnecessary check for instanceof MetaObject in toString() in Attribute.class
This was referenced Jun 24, 2016
Closed
Open
@p-a-s-c-a-l
Copy link
Member Author

resolved in #174

p-a-s-c-a-l added a commit that referenced this issue Jun 27, 2016
@p-a-s-c-a-l
#174 fix check for (Meta)Object in ObjectAttribute.toString (#173)
b39397a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p-a-s-c-a-l