Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Integration Test for taker-cli #207

Open
Shourya742 opened this issue Jul 7, 2024 · 1 comment · May be fixed by #244
Open

Implement Integration Test for taker-cli #207

Shourya742 opened this issue Jul 7, 2024 · 1 comment · May be fixed by #244
Labels
app App related works good first issue Good for newcomers tests Testing related improvements
Milestone

Comments

@Shourya742
Copy link

Task

  • Query the taker cli RPC port using an RPC call.

Details

  • This test should be similar to our existing integration tests.
  • Make queries to the taker's RPC port and verify the correctness of the responses.

Expected Outcome

  • The test should successfully query the taker's RPC port and return correct responses, validating the functionality of the taker's RPC.
@Shourya742 Shourya742 added the good first issue Good for newcomers label Jul 8, 2024
@mojoX911
Copy link

mojoX911 commented Jul 18, 2024

Further info:

This issue is for creating the first template of this type of test. It's okay if all the taker-cli commands are not covered in the solving PR. Once the template is ready we can add tests for further commands in subsequent PRs.

There is no RPC for taker-cli. takerr-cli is a REPL type of app. So each command has to be tested as a single executed process.

Approach:
Use the std::process::Command to issue a single taker-cli app command and evaluate the returned result.

@mojoX911 mojoX911 added tests Testing related improvements app App related works labels Jul 18, 2024
@mojoX911 mojoX911 changed the title Implement Integration Test for Taker's RPC Implement Integration Test for taker-cli Jul 18, 2024
@mojoX911 mojoX911 added this to the v0.1.0 milestone Jul 20, 2024
@KnowWhoami KnowWhoami linked a pull request Aug 23, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app App related works good first issue Good for newcomers tests Testing related improvements
Projects
Status: todo
Development

Successfully merging a pull request may close this issue.

2 participants