write integration test for taker cli app.

[KnowWhoami]

fixes #207

[mojoX911]

Approach Ack.

Needs restructuring.

[mojoX911]

Approach Ack.

Some more fixes.

[mojoX911]

We need a fee in this structure itself. That's not the same as the coinswap fee. Then use the fee used here to create the tx.

[mojoX911]

No fee and fee_rate is different. Doing fee_rate is difficult, because fee = fee_rate * tx_weight. And we don't know the tx_weight before signing the transaction. But we need the fee to create the outputs before signing the tx.

So it becomes a chicken and egg style problem.

One way to solve this is to pre-estimate the tx_weight, which is possible because its always single-sig p2wpkh type, which has a constant size of tx input.

This will get solved by BDK as it internally knows how to estimate input size from the descriptor.

For our purpose now having just the fee is will work.

[KnowWhoami]

• Whenever we create any sort of tx like funding, contract tx -> we take fee-rate in function parameters

coinswap/src/protocol/contract.rs

Line 382 in 7996388

pub fn create_senders_contract_tx(

coinswap/src/wallet/funding.rs

Line 123 in 7996388

fn create_funding_txes_random_amounts(

• Right now , we do not calculate fee of a tx , so we just assume fee= fee_rate.

• So we should also do the same for spend_from_wallet api which is currently taking fee as parameter.
  

  coinswap/src/wallet/direct_send.rs

  Line 67 in 7996388

  pub fn spend_from_wallet(

• IMO, it seems irrational from user perspective to give fee as argument while calling send-to-addresss .