Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up README and moving documentation to docs #12

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jodobear
Copy link

House cleaning for README and initiating structured docs.

TO DO:

  • Add fidelity bond doc
  • Update project Roadmap and TODO

Copy link

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a3e5477

The idea looks good. Maybe we can have a more clear name for the how_to doc?

Comment on lines +29 to 47
Check [Developer Resources](docs/developer_resources.md) on information on the protocol and further reading.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add build and test instructions here too? Just two lines of build the binary with cargo build, and run all the tests with cargo test. Its trivial, but just not written anywhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, added an "Install/Build from Source" section in the README and removed it from app_instructions

README.md Outdated
- [Protocol between takers and makers](#protocol-between-takers-and-makers)
- [Code Structure](#code-structure)
- [Further reading](#further-reading)
- [Docs](#docs)
- [Chris Belcher's personal roadmap for the project](#chris-belchers-personal-roadmap-for-the-project)
- [Community](#community)

## State of the project

The project is nearly usable, though it doesnt have all the necessary features yet. The code written so far is published for developers and power users to play around with. It doesn't have config files yet so you have to edit the source files to configure stuff. It is possible to run it on mainnet, but only the brave will attempt that, and only with small amounts.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add some further information on what this library is currently. Along the line of, it's a cli app written in rust as demo prototype of working with underlying coinswap subroutines and primitives.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated accordingly

docs/how_to.md Outdated
@@ -0,0 +1,169 @@
# Documentation on Creating Coinswap

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can call this an "Example Coinswap with teleport cli app".

We might not have this binary later. We will make sure to update this example accordingly.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated accordingly

@jodobear
Copy link
Author

ACK a3e5477

The idea looks good. Maybe we can have a more clear name for the how_to doc?

changed it to app_instructions

Copy link

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 13b166e

@rajarshimaitra rajarshimaitra merged commit b41ba4d into citadel-tech:master Jul 28, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants