musig2 apis #191
Closed
musig2 apis #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Dependency Changed walletcreatefundedpsbt with custom tx builder
This PR streamlines the default directory creation with a top level `get_home_dir` functions where test and production behavior is isolated. Plus a bunch of other fixes and some new functions required for Maker RPC.
Plus some more structuring of the directory app.
change discord
Maker RPC and some Auxiliary fix
fix: typos in enum names
update bitcoin to v0.32
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
6 tasks
use `Amount` instead of `u64`
add `directoryd` and `directory-cli` binary apps
Signed-off-by: wthrajat <rajatkhanduri290102@gmail.com>
Move master `Xpriv` generation from `Store` to `Wallet`
007harshmahajan
force-pushed
the
taproot-musig2
branch
from
e5b2e5a
to
6a7514d
Compare
|
@007harshmahajan can you make the tests pass so we can merge this? |
|
Currently working on it, will be done by Monday |
|
@007harshmahajan any update on this? The build and lint failure seems very simple to solve. |
will get it done today |
|
Few more clippy fixes left. |
007harshmahajan
force-pushed
the
taproot-musig2
branch
from
d136ce8
to
aeb8b67
Compare
|
All other lint issues are fixed in master, need to rebase from master |
6 tasks
007harshmahajan
force-pushed
the
taproot-musig2
branch
from
797af45
to
aeb8b67
Compare
mojoX911
approved these changes
Aug 1, 2024
Shourya742
requested changes
Aug 3, 2024
007harshmahajan
force-pushed
the
taproot-musig2
branch
from
7c4b3ac
to
316d67d
Compare
007harshmahajan
force-pushed
the
taproot-musig2
branch
2 times, most recently
from
bcb5b7b
to
f9ff32d
Compare
007harshmahajan
force-pushed
the
taproot-musig2
branch
from
f9ff32d
to
9c386c4
Compare
|
cant have rebase without clumsy PR, will add code with after merge of #227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently apis are just to make interactive signing session with
agg_signature,partial signatureandnonce_genmore will be adde accordingly depending on taproot requirments