ContractTxInfo construction into helper functions in Signature Request Methods

[wthrajat]

This PR refactors the construction of ContractTxInfoForSender and ContractTxInfoForRecvr into separate helper functions:

• build_contract_tx_info_for_sender: Handles the construction of the txs_info vector in the req_sigs_for_sender_once function. This encapsulates the logic for preparing the sender's contract transaction information, reducing clutter in the main function.

• build_contract_tx_info_for_recvr: Constructs the txs vector in the req_sigs_for_recvr_once function. Simplifies the code in the receiver's signature request method, making it easier to understand and maintain.

TLDR:

Solves 2 TODOs:

1. Take this construction out of function body.
2. Take the message construction out of the function body.

[Shourya742]

@wthrajat Can you squash the commits?

[mojoX911]

Nack.
There is no benefit of taking these one liners out in their own function.

This is in general a bad idea for maintainability.

[mojoX911]

@wthrajat if you can just address this #260 (comment) then this is good for merge.

Instead of taking the message construction in a new function, keep them in the old call site itself and move them out from the send function.

[wthrajat]

@mojoX911 I’ve removed the redundant TODO in req_sigs_for_sender_once() and moved the message construction outside of the send_message() call in req_sigs_for_recvr_once().

The TODO comment was a bit confusing as I thought it referred to moving the construction outside the parent functions rather than the send_message() calls.

[mojoX911]

Yes thats my bad. It was confusing. This is good to go now. Merging after the CI passes.

[mojoX911]

ACK