Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: todos, .gitignore, cleanups, broken links, readme, milestones, grammar #89

Merged
merged 8 commits into from
Jan 24, 2024

Conversation

wthrajat
Copy link
Collaborator

Making a PR only for updating the milestone would be an overkill so I made some quick fixes alongside.

  1. Fix todo: publickeys magic numbers are now not hardcoded.
  2. Fix todo: unwrap to Result for better error handling.
  3. We now don't need */temp-files in .gitignore.
  4. Docs run_teleport.md and developer_resources.md have been renamed, but not at all places. Also we should use relative URLs instead of hardcoded. They work bad when in branch other than master and in forks.
  5. Remove old information in src/protocol/messages.rs
  6. Milestone and readme.

Copy link

codecov bot commented Jan 23, 2024

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (e6dcd03) 68.86% compared to head (0a3f69c) 68.80%.

Files Patch % Lines
src/scripts/wallet.rs 0.00% 17 Missing ⚠️
src/wallet/direct_send.rs 0.00% 1 Missing ⚠️
src/wallet/funding.rs 0.00% 1 Missing ⚠️
src/wallet/swapcoin.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   68.86%   68.80%   -0.06%     
==========================================
  Files          28       28              
  Lines        5771     5773       +2     
==========================================
- Hits         3974     3972       -2     
- Misses       1797     1801       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@rajarshimaitra rajarshimaitra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 0a3f69c

@rajarshimaitra rajarshimaitra merged commit dda5c2d into citadel-tech:master Jan 24, 2024
8 checks passed
@wthrajat wthrajat self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants