Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retain original comments in CSL files #160

Open
SteveRidout opened this issue Oct 29, 2012 · 2 comments
Open

Retain original comments in CSL files #160

SteveRidout opened this issue Oct 29, 2012 · 2 comments

Comments

@SteveRidout
Copy link
Member

Currently comments are stripped out of the CSL file on import since this makes it easier to match the XML node numbering used in citeproc's reverse mapping support.

These comments should be retained.

It appears especially disrespectful now that we add our own "This style was edited with..." comment to output files.

SteveRidout added a commit that referenced this issue Oct 29, 2012
@rmzelle note that any XML comments are currently stripped out, see #160

refs #143
@rmzelle
Copy link
Member

rmzelle commented Oct 29, 2012

FWIW, in my own script to standardize the ordering of elements in the cs:info section I do the following: I keep comments (plural) at the top and any comment (singular) at the bottom of the cs:info section at their respective positions. Other comments are kept with the preceding XML element.

https://github.com/citation-style-language/utilities/blob/master/csl-reindenting-and-info-reordering.py#L71

@rmzelle
Copy link
Member

rmzelle commented Apr 9, 2015

@SteveRidout, I would be ever so grateful if you could fix this. See e.g. https://github.com/citation-style-language/styles/pull/1504/files for an example where comment removal is especially problematic.

Is there anything in citeproc-js that could be changed to make this easier to fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants