Delete prefix=" " in second field if second-field-align="flush" #1349
Conversation
(reference to 1346) Searched for ``` <bibliography[^>]*second-field-align="flush"[^>]*>.*<layout[^>]*>\r\n\s*<text variable="citation-number"[^>]*/>\r\n\s*<text[^>]*prefix=" ```
Delete prefix=" " in second field if second-field-align="flush"
|
excellent, thanks! |
|
It might be good to keep track of all these problematic patterns we identified, e.g. in the wiki or so, with a short description, the regex to find the pattern, and the fixes. We do these clean-ups once in a while, but these patterns often slowly sneak back in again. |
|
Yeah, documentation is always a good idea. Can you prepare an appropriate place in the wiki? Maybe, for a start, we can make a list of the corresponding pull requests... |
|
I like it On Thu, Jan 22, 2015 at 9:59 AM, Rintze M. Zelle notifications@github.com
Sebastian Karcher, PhD |
|
+1 |
|
I cannot edit wikipages in the csl-styles repo. At least I don't see any "edit" button... |
|
I invited you to become a team member for the "styles" and "locales" repos, which also means you should now have direct push access to those. If you push to the repos, please first run the Travis CI tests locally, and be careful in general. You can of course also just keep using pull requests. |
|
also, if possible enable two-factor authentication for github to be on the safe side (since this is going out directly to clients) |
|
(the alternative is to open up the wiki to everybody, but I never found a good way to get notifications when people make edits) |
|
FWIW, my rule of thumb is to never push anything I did in bulk, I always use pull requests from a separate branch for those. And if you don't want to set up travis locally, I'd stick with pull requests--you can merge them yourself, especially for new styles & smaller edits. |
|
Thank you for the trust in me! I happily accepted the invitation. However, I would like to continue to work as before. I don't see currently a reason for me to create direct pushs. 2Way authentification is at the moment not a good option for me, thus I will leave that as it is now. |
|
Note that you can use 2-factor authentication without text-messages. You just need a smartphone: https://help.github.com/articles/configuring-two-factor-authentication-via-a-totp-mobile-app/ |
|
Yeah, but I don't have a smartphone... |
|
That's harder, then ;). |
|
I documented this pattern on the new wiki page. Hope it is close to what you had in mind. |
|
Did you fix the problem with a regex-based find and replace, or by hand? If the former, you could document those expressions as well. |
|
I did look at them manually and correct it. But actually it would have been possible to automatically replace them (I added a sentence) |
|
Delete unnecessary et-al-subsequent statements |
|
Hi @zuphilip, I revoked your team status again. It's not that we don't trust you, but any account without 2-factor authentication is rather sensitive to hacking (see e.g. https://github.com/blog/1698-weak-passwords-brute-forced ). I made the wiki of the "styles" repo editable for members of the public, so you can still edit it. If, in the future, you get a smartphone and can set up 2-factor authentication, we'd be happy to give you write access again, if you'd like that. |
|
Okay. I am still on the honor roll of CSL, that sounds good for me. I will let you know if other write access would become handy and I have the technical requirements for them. |
(reference to #1346)
Searched for